Skip to content

fix(shared,clerk-js): raise @tanstack/query-core floor to ^5.100.6#8432

Merged
jacekradko merged 5 commits intomainfrom
jacek/bump-query-core-cdn
Apr 30, 2026
Merged

fix(shared,clerk-js): raise @tanstack/query-core floor to ^5.100.6#8432
jacekradko merged 5 commits intomainfrom
jacek/bump-query-core-cdn

Conversation

@jacekradko
Copy link
Copy Markdown
Member

@jacekradko jacekradko commented Apr 30, 2026

Summary

  • Raises the @tanstack/query-core floor from ^5.90.16 to ^5.100.6 in @clerk/shared and @clerk/clerk-js
  • Pulls query-core@5.100.6 into the lockfile so the CDN-published clerk-js bundle embeds it (verified: isFetched now ships in query-core-vendors_clerk.browser_*.js)

Why

@clerk/shared and the production clerk-js CDN bundle share an implicit cross-bundle contract: shared constructs QueryObserver instances against Query objects from clerk-js's QueryClient. After #8417 loosened the pin, consumer-side @clerk/shared resolved query-core to 5.100.x (which adds Query.isFetched() and has the Observer call it), while the CDN bundle still embedded 5.90.16. The Observer then crashed calling isFetched() on the older Query objects.

Fixes #8428.

Raising the floor keeps consumer dedupe working with ^5.100.6 (so #8417's Vite/Bun repro should still resolve) and ensures the CDN bundle used for this release embeds the same query-core version that triggered the reporter's crash. The class of bug is structural — the cross-bundle contract on query-core shouldn't exist — and a follow-up will move QueryClient ownership into @clerk/shared to eliminate it. This PR is the patch.

Test plan

  • pnpm --filter @clerk/shared test -- --run (1069/1069 pass)
  • pnpm --filter @clerk/clerk-js build succeeds and query-core-vendors_*.js chunk contains isFetched
  • Mixed-version smoke test: 5.100.6 QueryObserver + 5.90.16 QueryClient reproduces query.isFetched is not a function; 5.100.6 observer/client succeeds
  • Reproduce 7.2.8 crash with the original repro app, swap to this build, verify resolved
  • Re-run the Lovable-shape repro (Vite + Bun, dedupe to 5.100.x) — should still resolve cleanly

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Apr 30, 2026 5:33pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

🦋 Changeset detected

Latest commit: 13245fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/shared Patch
@clerk/clerk-js Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/hono Patch
@clerk/localizations Patch
@clerk/msw Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/react Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 38218092-bc5c-4a56-b16e-ee27e24494b3

📥 Commits

Reviewing files that changed from the base of the PR and between 5e8390e and 13245fe.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .changeset/raise-query-core-floor.md
  • packages/clerk-js/package.json
  • packages/shared/package.json
  • pnpm-workspace.yaml
✅ Files skipped from review due to trivial changes (2)
  • pnpm-workspace.yaml
  • packages/shared/package.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/clerk-js/package.json
  • .changeset/raise-query-core-floor.md

📝 Walkthrough

Walkthrough

This PR raises the required @tanstack/query-core floor to ^5.100.6 by adding it to the pnpm workspace version catalog and updating the dependency specifiers in packages/clerk-js/package.json and packages/shared/package.json. It also adds a Changesets entry documenting a runtime failure where QueryObserver calls Query.isFetched() while a bundled older query-core lacks that method, causing TypeError: e.isFetched is not a function.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: raising the @tanstack/query-core floor version in two packages to a specific version number.
Description check ✅ Passed The PR description is directly related to the changeset, explaining why the @tanstack/query-core version was raised, the runtime issue it fixes, and including test results.
Linked Issues check ✅ Passed The PR successfully addresses the root cause documented in #8428: the version mismatch between consumer @clerk/shared and the CDN-embedded clerk-js bundle by raising the query-core floor to ^5.100.6 in both packages.
Out of Scope Changes check ✅ Passed All changes are directly scoped to addressing the version mismatch: updating package.json files, the workspace catalog, and creating a changeset entry. No unrelated modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 30, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8432

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8432

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8432

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8432

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8432

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8432

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8432

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8432

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8432

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8432

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8432

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8432

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8432

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8432

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8432

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8432

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8432

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8432

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8432

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8432

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8432

commit: 13245fe

@jacekradko jacekradko changed the title fix(shared,clerk-js): raise @tanstack/query-core floor to ^5.100.5 fix(shared,clerk-js): raise @tanstack/query-core floor to ^5.100.6 Apr 30, 2026
@jacekradko jacekradko merged commit 1bfd8ab into main Apr 30, 2026
39 of 43 checks passed
@jacekradko jacekradko deleted the jacek/bump-query-core-cdn branch April 30, 2026 17:55
@CodingFabian
Copy link
Copy Markdown

I can confirm it appears to be fixed now. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@clerk/nextjs 7.2.8 breaks with e.isFetched' is undefined

4 participants